Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 235e477017
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| --hash=sha256:f55ba01150f52b1027829b50d70ef1dafd9821ea82905b63936668403c3b471e \ | ||
| --hash=sha256:f653490b33e9c3a4c1c01d41bc2aef08f9475af51146e4a7710c450cf9761598 \ | ||
| --hash=sha256:fa2d1337dc61c8dc417fbccf20f6d1e139896a30721b7f1e832b2bb6ef4eb6c4 | ||
| numpy==2.4.3 \ |
There was a problem hiding this comment.
Wire NumPy into the Bazel target before bumping it
This lockfile change does not actually update any in-tree runtime dependency: a repo-wide search only finds NumPy imported in ecc/rtl/secded_codegen/secded_codegen.py:5, but ecc/rtl/secded_codegen/BUILD.bazel:9-15 does not depend on @bedrock-rtl-pypi//numpy:pkg. In practice Bazel will keep using whatever transitive NumPy comes from @eccgen//eccgen:matrix_parser, so this PR leaves the generated-code path on an uncontrolled version while making it look like the repo was upgraded to 2.4.3.
Useful? React with 👍 / 👎.
235e477 to
afacc2f
Compare
Bumps [numpy](https://github.com/numpy/numpy) from 2.1.3 to 2.4.3. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v2.1.3...v2.4.3) --- updated-dependencies: - dependency-name: numpy dependency-version: 2.4.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
afacc2f to
67624ec
Compare
|
Superseded by #1032. |
Bumps numpy from 2.1.3 to 2.4.3.
Release notes
Sourced from numpy's releases.
... (truncated)
Changelog
Sourced from numpy's changelog.
... (truncated)
Commits
8bcb2e7Merge pull request #30974 from charris/prepare-2.4.39a2b5eeREL: Prepare for the NumPy 2.4.3 releasea822ac2Merge pull request #30973 from charris/backport-30961039bf54MAINT: update openblas (#30961)254bafaMerge pull request #30955 from charris/backport-308790cc7d38ENH: Test .kind not .char in np.testing.assert_equal (#30879)9ee571dMerge pull request #30957 from charris/backport-30918f302a16Merge pull request #30958 from charris/backport-30938d240a09MAINT: Don't use vulture 2.15, it has false positives4fc08e9MAINT: Don't use vulture 2.15, it has false positivesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)